[Libguestfs] [PATCH v2v 0/2] v2v: nbdkit: Don't use password=- parameter.

[Pino Toscano]

On Monday, 1 June 2020 18:43:36 CEST Richard W.M. Jones wrote:
> Part 2 fix for:
> https://bugzilla.redhat.com/show_bug.cgi?id=1842440
> 
> Actually this fix on its own should be sufficient, but probably we
> want the nbdkit fixes too.
> 
> Note this uses actual OCaml 4.05 features!  ("let open" and the
> Unix.tcgetattr functions).

BTW Unix.tcgetattr is very old, even old 3.11 had it (found in some old
tests of mine).

LGTM; IMHO printing user/host in the password prompt would make it more
clear as to for which host the password is asked.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20200615/777e4090/attachment.sig>