[Libguestfs] [PATCH nbdkit v2 3/3] build: Rename configure --without-linuxdisk -> --disable-linuxdisk

[Richard W.M. Jones]

When I was reviewing this I forgot the faintly ridiculous rules that
autoconf uses for --enable/disable vs --with/without:

  https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/Package-Options.html
  https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/External-Software.html

Since this is disabling an intrinsic feature of the software (a
plugin) it should use --disable.

Updates: commit 2a3efc5836df3d55d304cc4b3ea2800b5e93831a
---
 configure.ac | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 7c15ed0f..3cbbeb9d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -483,17 +483,17 @@ AS_IF([test "$GNUTLS_LIBS" != ""],[
     LIBS="$old_LIBS"
 ])
 
-AC_ARG_WITH([linuxdisk],
-    [AS_HELP_STRING([--without-linuxdisk],
+AC_ARG_ENABLE([linuxdisk],
+    [AS_HELP_STRING([--disable-linuxdisk],
                     [disable linuxdisk plugin @<:@default=check@:>@])],
     [],
-    [with_linuxdisk=check])
+    [enable_linuxdisk=check])
 dnl Check for mke2fs -d (used by linuxdisk plugin).  There are two
 dnl possible outcomes that we care about: (1) We have mke2fs and
 dnl it supports the -d option.  (2) We either don't have mke2fs
 dnl or it's too old to support the -d option (eg. on RHEL 7).
 mke2fs_with_d=no
-AS_IF([test "$with_linuxdisk" != "no"], [
+AS_IF([test "$enable_linuxdisk" != "no"], [
     AC_MSG_CHECKING([for mke2fs supporting the -d option])
     AS_IF([mke2fs -V >/dev/null 2>&1], [
         AS_IF([LANG=C mke2fs -d 2>&1 | grep -sq "option requires an argument"], [
-- 
2.25.0