[Libguestfs] [PATCH nbdkit 0/9] Create libnbdkit.so

[Eric Blake]

On 3/26/20 1:25 PM, Richard W.M. Jones wrote:
> This creates libnbdkit.so as discussed in the following thread:
> https://www.redhat.com/archives/libguestfs/2020-March/thread.html#00203
> 
> test-delay-shutdown.sh fails for unclear reasons.
> 
> This series starts by reverting "tests: Don't strand hung nbdkit
> processes" which is because several other tests fail randomly unless I
> revert this patch.  I didn't investigate this yet so it could be
> caused by this patch series.

Given a log that you showed me, you hit a case where test-nbd-tls-psk.sh 
hung; with my patch reverted, that hung process just results in an 
unreaped orphan process left on your machine (so that you could get back 
to stable testing of the rest of your series), with my patch in place, 
that hang now turns into a testsuite failure.  The fact that the hang is 
intermittent is still what I'm trying to fix in libnbd/nbdkit (I'm 
hoping to post patches soon that add the use of gnutls_bye in more places).

> 
> libtool on Linux doesn't appear to care about -undefined/-no-undefined.
> See comments in commit messages.
> 
> The patch is kind of ugly TBH.  Personally I don't have a problem with
> plugins having undefined references that are later resolved to the
> main binary, but I understand that Windows is broken in this regard.
> 
> Rich.
> 
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org