[Libguestfs] [PATCH virt-v2v] v2v: Use LIBGUESTFS_CFLAGS/LIBS when compiling and linking.

[Pino Toscano]

On Tuesday, 10 March 2020 16:06:20 CET Richard W.M. Jones wrote:
> Allows virt-v2v to be compiled against the libguestfs build directory.

This is not just about building against an uninstalled libguestfs,
rather about building against libguestfs no matter where it is
installed (so not just in default system paths).

> ---
>  v2v/Makefile.am | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/v2v/Makefile.am b/v2v/Makefile.am
> index 2a196d45d..104420d13 100644
> --- a/v2v/Makefile.am
> +++ b/v2v/Makefile.am
> @@ -197,6 +197,7 @@ virt_v2v_CPPFLAGS = \
>  	-I$(top_srcdir)/lib
>  virt_v2v_CFLAGS = \
>  	$(WARN_CFLAGS) $(WERROR_CFLAGS) \
> +	$(LIBGUESTFS_CFLAGS) \
>  	$(LIBVIRT_CFLAGS) \
>  	$(LIBOSINFO_CFLAGS)
>  
> @@ -230,6 +231,7 @@ endif
>  
>  OCAMLCLIBS = \
>  	-lqemuopts \
> +	$(LIBGUESTFS_LIBS) \
>  	$(LIBVIRT_LIBS) \
>  	$(LIBXML2_LIBS) \
>  	$(JANSSON_LIBS) \

LGTM.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20200311/41f3dd63/attachment.sig>