[Libguestfs] [PATCH libnbd 1/3] tests: Don't use <config.h> in simple compile tests.

Pino Toscano ptoscano at redhat.com
Fri Mar 13 12:00:06 UTC 2020


On Thursday, 12 March 2020 23:46:55 CET Richard W.M. Jones wrote:
> For these simple compile tests where we want to ensure that a basic
> external program could be compiled using libnbd, we shouldn't include
> <config.h>.  This is because we want to test here that <libnbd.h> can
> stand alone, without needing anything defined by the GNU autotools
> infrastructure.
> 
> Of course we can use <config.h> in other test programs where we aren't
> evaluating if <libnbd.h> works standalone.
> ---

LGTM.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20200313/fd1bda23/attachment.sig>


More information about the Libguestfs mailing list