[Libguestfs] [PATCH libnbd 3/3] build: Test new pkgconf file.

[Eric Blake]

On 3/14/20 9:44 AM, Richard W.M. Jones wrote:
> On Fri, Mar 13, 2020 at 12:57:52PM +0100, Pino Toscano wrote:
>> On Thursday, 12 March 2020 23:46:57 CET Richard W.M. Jones wrote:
>>> Unfortunately only tests the ./run version rather than the real one.
>>> ---
>>
>> Is it worth it though? The new pkg-config file won't be deployed to
>> users, and it should (hopefully) not break if the locations of the
>> sources are not changed.
>>
>> Otherwise a small hint: rename it to e.g. local-pkg-config.sh to
> 
> I think I'll drop this patch.  I was kind of hoping that by posting it
> someone would think of a way to test the real .pc file :-)

Automake produces 'make check' (test the just-built uninstalled 
binaries) and 'make installcheck' (test the installed binaries).  If 
there is an easy way to set up the test environment so that we use ./run 
during 'make check' but avoid it during 'make installcheck', then 
anything you do to test the local-pkg-config during 'make check' will 
immediately turn into a test of the real .pc file during 'make 
installcheck'.

However, the way we currently do it, by globally setting LOG_COMPILER in 
tests/Makefile.am, does not distinguish between the two setups, so it 
would need a tweak, and I don't know offhand what that tweak would look 
like.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org