[Libguestfs] [PATCH nbdkit 3/3] python: Remove extraneous static keyword

Richard W.M. Jones rjones at redhat.com
Mon Mar 23 14:19:01 UTC 2020


On Mon, Mar 23, 2020 at 09:08:25AM -0400, Frank Gu wrote:
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include
> -I../../common/utils -I/usr/include/python3.7m -g -O2 -MT
> nbdkit_python_plugin_la-python.lo -MD -MP -MF
> .deps/nbdkit_python_plugin_la-python.Tpo -c python.c  -DDLL_EXPORT -DPIC -o
> .libs/nbdkit_python_plugin_la-python.o
> python.c:228:1: error: external linkage required for symbol
> ‘create_nbdkit_module’ because of ‘dllexport’ attribute
>   228 | create_nbdkit_module (void)
>       | ^~~~~~~~~~~~~~~~~~~~

I see.  I think this is actually a bug in the Python headers (look at
how PyMODINIT_FUNC is defined), but as there's very little chance of
fixing those any time soon, I will take your patch 3/3 into nbdkit in
a minute.

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/




More information about the Libguestfs mailing list