[Libguestfs] [PATCH] [v2] WIP: ddrescue mapfile filter

[François Revol]

Le 01/05/2020 à 23:16, Richard W.M. Jones a écrit :
> On Fri, May 01, 2020 at 09:16:14PM +0200, François Revol wrote:
>> +nbdkit_ddrescue_filter_la_LDFLAGS = \
>> +	-module -avoid-version -shared \
>> +	-Wl,--version-script=$(top_srcdir)/filters/filters.syms \
>> +	$(NULL)
> 
> Still lacking $(SHARED_LDFLAGS) here?
> 
> The rest seems fine (but see Eric's suggestion about the documentation).
> 
> We'll have to hold this one until 1.20 has been released, should
> be soon.

I see 1.20 is out, I'll send a v3, hopefully it can be merged now.

Btw, Why doesn't SHARED_LDFLAGS include the -shared?
Since not all platforms/linkers actually use this flag (BeOS used
-nostart but that was rather hackish since it's a bit different (even
apps where shared objects to allow loading them as replicants in other
apps)).
So I'd find it better to have this flag in the variable too.

François.