[Libguestfs] [PATCH v2v] v2v: Remove extraneous '=' when setting --bandwidth/--bandwidth-file.

Pino Toscano ptoscano at redhat.com
Thu May 28 12:42:53 UTC 2020


On Thursday, 28 May 2020 12:51:16 CEST Richard W.M. Jones wrote:
> Commit c3a54d6aed6dfc65f9ffa59976bb8d20044c03a8 ("v2v: Add standalone
> nbdkit module.") was supposed to be a simple refactoring but it broke
> the --bandwidth and --bandwidth-file options (amongst other things).
> 
> Because of an extra '=' character which was accidentally left over, it
> would add an extra character in the nbdkit-rate-filter command line.
> For example:
> 
>   virt-v2v .. --bandwidth 200M
> 
> would invoke:
> 
>   nbdkit .. --filter rate rate==200M
> 
> which causes a parse error.  The --bandwidth-file option does not
> invoke a parse error but does not work, for similar reasons.
> 
> Thanks: Ming Xie
> ---

Remember to mention RHBZ#1841096 in the commit message.

Otherwise, LGTM.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20200528/a137155b/attachment.sig>


More information about the Libguestfs mailing list