[Libguestfs] [libnbd PATCH 1/3] api: Add get_nr_meta_contexts, clear_meta_contexts

Richard W.M. Jones rjones at redhat.com
Tue Sep 29 11:26:40 UTC 2020


On Mon, Sep 28, 2020 at 05:05:16PM -0500, Eric Blake wrote:
> +  "get_meta_context", {
> +    default_call with
> +    args = [ Int "i" ]; ret = RString;

Previously we have only used the Int parameter type for things which
are plausibly integers (timeouts, signal numbers).  This one really
ought to be an unsigned or better still a size_t.  Would it help if I
provided a SizeT type for the generator?

But in general yes this patch is obvious so ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list