[Libguestfs] [libnbd PATCH 1/3] api: Add get_nr_meta_contexts, clear_meta_contexts

Richard W.M. Jones rjones at redhat.com
Tue Sep 29 14:34:05 UTC 2020


On Tue, Sep 29, 2020 at 06:47:47AM -0500, Eric Blake wrote:
> On 9/29/20 6:26 AM, Richard W.M. Jones wrote:
> >On Mon, Sep 28, 2020 at 05:05:16PM -0500, Eric Blake wrote:
> >>+  "get_meta_context", {
> >>+    default_call with
> >>+    args = [ Int "i" ]; ret = RString;
> >
> >Previously we have only used the Int parameter type for things which
> >are plausibly integers (timeouts, signal numbers).  This one really
> >ought to be an unsigned or better still a size_t.  Would it help if I
> >provided a SizeT type for the generator?
> 
> If we take SizeT as parameter for this one, we probably want to
> return an ssize_t for get_nr_meta_contexts, rather than RInt.  Does
> the name RSizeT that returns ssize_t make sense?

Yes we should do this.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org




More information about the Libguestfs mailing list