[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [libnbd RFC PATCH] First stab at CI infrastructure



On Wed, Apr 07, 2021 at 04:55:17PM +0200, Martin Kletzander wrote:
> Polite ping.  Any thoughts?  Anything you'd like to change?

I didn't particularly understand any of it; but it's what we need so
looks good!

One bug: All the new files that have been added probably need to be
added to the top-level Makefile.am EXTRA_DIST, certainly if they would
be in any way useful in the tarball.  However if they are not useful
in the tarball then the target "maintainer-check-extra-dist" (also in
Makefile.am) must be modified to ignore these files when I do
"make && make dist && make maintainer-check-extra-dist".

I also looked at the results:

  https://gitlab.com/nertpinx/libnbd/-/pipelines?scope=all&page=1

and choosing the top "failed" link arbitrarily takes me to:

  https://gitlab.com/nertpinx/libnbd/-/pipelines/278989630

where there are some failures.  We don't support mingw* platforms for
libnbd (we do for nbdkit), so for libnbd those platforms can
immediately be dropped.

But there are some other non-mingw failures, again picking one
at random:

  https://gitlab.com/nertpinx/libnbd/-/jobs/1140619393

the failure is:

  go install: version is required when current directory is not in a module

which is (or was) a real bug!  I've since fixed it upstream, but it
seems to show the thing works.

As far as I know libnbd should currently build on Rawhide, so could
you pull in the updates, drop mingw*, and see if the tests start to
pass?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]