[Libguestfs] [PATCH virt-v2v] v2v: -o rhv-upload: Enable multi-conn
Richard W.M. Jones
rjones at redhat.com
Tue Aug 3 19:31:46 UTC 2021
On Tue, Aug 03, 2021 at 02:20:01PM -0500, Eric Blake wrote:
> On Mon, Aug 02, 2021 at 08:41:20AM +0100, Richard W.M. Jones wrote:
> > ---
> > v2v/rhv-upload-plugin.py | 4 ++++
> > 1 file changed, 4 insertions(+)
> > diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py
> > index a3d578176..51e9b33f7 100644
> > --- a/v2v/rhv-upload-plugin.py
> > +++ b/v2v/rhv-upload-plugin.py
> > @@ -169,6 +169,10 @@ def open(readonly):
> > }
> > +def can_multi_conn(h):
> > + return True
> Should this be h['can_flush'] instead of True?
In the later version this is different(-ly bad):
> Are we guaranteed that imageio guarantees a consistent image across
> all other http connections when a flush is received on a single http
That's a question for Nir (CC'd).
However it's likely true anyway since even in the the current
implementation it flushes all HTTP connections inside the nbdkit
and I didn't change this behaviour in the proposed patches.
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
More information about the Libguestfs