[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] libnbd 1.6 build fails with Python code style error



On Sun, Jan 10, 2021 at 01:34:27AM +0100, Thomas Weißschuh wrote:
> Hi all,
> 
> the checks for libnbd 1.6 fail for me in python/pycodestyle.sh.
> Log output below.
> It seems the CI machine is missing the flake8 installation.
> 
> Making check in python
> make[1]: Entering directory '.../python'
> make  check-am
> make[2]: Entering directory '.../python'
> make  check-TESTS
> make[3]: Entering directory '.../python'
> make[4]: Entering directory '.../python'
> FAIL: pycodestyle.sh
> PASS: run-python-tests
> ============================================================================
> Testsuite summary for libnbd 1.6.0
> ============================================================================
> # TOTAL: 2
> # PASS:  1
> # SKIP:  0
> # XFAIL: 0
> # FAIL:  1
> # XPASS: 0
> # ERROR: 0
> ============================================================================
> See python/test-suite.log
> ============================================================================
> 
> 
> .../python/t/590-aio-copy.py:56:43: E211 whitespace before '('
> .../t/590-aio-copy.py:57:11: E127 continuation line over-indented for visual
> +indent
> FAIL pycodestyle.sh (exit status: 1)

Oh yes, sorry, my fault!  I didn't have flake8 installed so the
regression test was skipped for me, and I pushed a change which didn't
conform with the Python coding standard.

I added this fix.

https://github.com/libguestfs/libnbd/commit/11a8b398205d198e17dfdb891f50b6e38ced62c7

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]