[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2 1/7] v2v: output_rhv_upload: Require nbdkit >= 1.22



On Sun, Jan 24, 2021 at 02:55:48PM +0200, Nir Soffer wrote:
> nbdkit 1.22 provides API_VERSION 2 and parallel threading model for the
> python plugin. This version is available in RHEL AV 8.3.0.
> 
> Signed-off-by: Nir Soffer <nsoffer redhat com>
> ---
>  v2v/output_rhv_upload.ml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml
> index b5cc95b9..3cf3bf4c 100644
> --- a/v2v/output_rhv_upload.ml
> +++ b/v2v/output_rhv_upload.ml
> @@ -84,11 +84,11 @@ let parse_output_options options =
>  
>    { rhv_cafile; rhv_cluster; rhv_direct; rhv_verifypeer; rhv_disk_uuids }
>  
> -(* In theory even very old versions of nbdkit might work, but as
> - * with [Nbdkit_sources] check for at least 1.12.
> +(* We need nbdkit >= 1.22 for API_VERSION 2 and parellel threading model

Ooops, another one: s/parellel/parallel/

> + * in the python plugin.
>   *)
> -let nbdkit_min_version = (1, 12, 0)
> -let nbdkit_min_version_string = "1.12.0"
> +let nbdkit_min_version = (1, 22, 0)
> +let nbdkit_min_version_string = "1.22.0"
>  
>  let nbdkit_python_plugin = Config.nbdkit_python_plugin
>  let pidfile_timeout = 30
> -- 
> 2.26.2

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]