[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH nbdkit 1/2] cow: Return NBDKIT_CACHE_NATIVE from can_cache.



On 1/26/21 4:07 AM, Richard W.M. Jones wrote:
> Seems as if this was a typo in the original commit.  It happens that
> both constants have the same value.
> 
> Fixes: commit 90438c112cedbaab6afdcc85560c54d015c67e54

Yep, my fault for that typo. Good to go.

> ---
>  filters/cow/cow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/filters/cow/cow.c b/filters/cow/cow.c
> index 51ca64a4..cbb072f1 100644
> --- a/filters/cow/cow.c
> +++ b/filters/cow/cow.c
> @@ -183,7 +183,7 @@ cow_can_cache (struct nbdkit_next_ops *next_ops, void *nxdata, void *handle)
>    int r = next_ops->can_cache (nxdata);
>    if (r == -1)
>      return -1;
> -  return NBDKIT_FUA_NATIVE;
> +  return NBDKIT_CACHE_NATIVE;
>  }
>  
>  /* Override the plugin's .can_fast_zero, because our .zero is not fast */
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]