[Libguestfs] GSoC: Adding liburing dependency to libnbd

Richard W.M. Jones rjones at redhat.com
Mon Jun 7 08:42:40 UTC 2021


On Sun, Jun 06, 2021 at 08:26:08PM +0530, Abhay Raj Singh wrote:
> I went with libxml2 like for now
> GitLab commit: https://gitlab.com/rathod-sahaab/libnbd/-/commit/e9b90859c0a286d7023efd40080b4d88c978d083

Yes you'll need to detect liburing using a configure test like this.

> 
> AC_ARG_WITH([liburing],
>     [AS_HELP_STRING([--without-liburing],
>                     [disable use of liburing i.e. io_uring for asynchronus io @<:@default=check@:>@])],
>     [],
>     [with_liburing=check])
> AS_IF([test "$with_liburing" != "no"],[
>     PKG_CHECK_MODULES([LIBURING], [liburing], [
>         AC_SUBST([LIBURING_CFLAGS])
>         AC_SUBST([LIBURING_LIBS])
>         AC_DEFINE([HAVE_LIBURING],[1],[liburing found at compile time.])
>     ], [
>         AC_MSG_WARN([liburing not found, io_uring support disabled.])
>     ])
> ])
> AM_CONDITIONAL([HAVE_LIBURING], [test "x$LIBURING_LIBS" != "x"])

Looks reasonable to me.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org




More information about the Libguestfs mailing list