[Libguestfs] [PATCH libnbd 2/2] examples: copy-libev.c: Simple sparsifying

Richard W.M. Jones rjones at redhat.com
Fri Mar 5 17:49:24 UTC 2021


I would just say about the examples that often it's better if they are
completely stand-alone (since we want people to copy and adapt the
code).  That would imply not using the common/ header file, but either
inlining the function or using a less efficient but simpler loop.
This is also the reason why the examples don't #include <config.h>

Anyway the patch is fine, but IMO could be improved as above.

ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list