[Libguestfs] [nbdkit PATCH v3 04/16] server: Rename struct handle to struct context

Richard W.M. Jones rjones at redhat.com
Tue Mar 9 14:05:54 UTC 2021


On Fri, Mar 05, 2021 at 05:31:08PM -0600, Eric Blake wrote:
> Reduce the confusion between the user's (filter or plugin) void
> *handle, and the extra context information we need to utilize that
> handle.  This will also make it easier for an upcoming patch to update
> the signature of various backend_* functions called from
> nbdkit_next_ops.  Also delete the nr_handles field, which was unused
> and always reflected 'top->i+1'.  The HANDLE_* enum values are left
> unchanged, as they represent what we know about the user's handle, and
> therefore what user cleanup functions we still need to call.
> ---
>  server/internal.h    |  22 ++--
>  server/backend.c     | 270 +++++++++++++++++++++----------------------
>  server/connections.c |  13 +--
>  3 files changed, 151 insertions(+), 154 deletions(-)
[...]

ACK.

This is also both a worthwhile and basically independent
change, so I think this should go early.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org




More information about the Libguestfs mailing list