[Libguestfs] [PATCH libguestfs 1/1] launch: libvirt, direct: Add force_tcg backend setting.

[Richard W.M. Jones]

On Mon, Mar 15, 2021 at 05:57:14PM +0200, Sam Eiderman wrote:
> Just noticed I replied off-list.
> 
> I will rework this commit to use the suggested enum, both in libvirt
> and direct then.
> Not sure if we need a single place to define it (since it's only
> relevant for two of these backends).
> Might just define it as:
> enum { BEST_ACCEL, FORCE_TCG, FORCE_KVM } accel;
> in both places as you suggested.

Could it go in lib/guestfs-internal.h ?

> Do I need to worry about documentation in this commit? force_tcg is
> pretty well documented.

Worth adding it to the man page I think (lib/guestfs.pod).

RIch.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/