[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [libnbd PATCH 1/5] Fix test requirements



On Thu, May 06, 2021 at 01:30:06PM +0200, Martin Kletzander wrote:
> Some tests have extra dependencies that may be missing in minimal
> deployments (e.g. hexdump), some require kernel modules or support (nbd, fuse)
> and others need qemu, but were written to only work with qemu-kvm binary.
> 
> All these were fixed to my best knowledge, but of course they are still not
> perfect.
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  tests/functions.sh.in                 | 21 +++++++++++++++++++++
>  interop/dirty-bitmap.sh               |  4 ++--
>  copy/copy-block-to-nbd.sh             |  1 +
>  copy/copy-nbd-to-block.sh             |  1 +
>  copy/copy-nbd-to-nbd.sh               |  1 +
>  copy/copy-nbd-to-small-block-error.sh |  1 +
>  copy/copy-tls.sh                      |  1 +
>  fuse/test-file-mode.sh                |  1 +
>  fuse/test-nbdkit.sh                   |  1 +
>  fuse/test-qcow2.sh                    |  1 +
>  info/info-map-qemu-dirty-bitmap.sh    |  4 ++--
>  11 files changed, 33 insertions(+), 4 deletions(-)

Eric picked up a few minor mistakes in his review, but with those
fixed this one looks good.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]