[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [libnbd PATCH 2/5] Change golang/run_tests.sh shebang to bash



On Thu, May 06, 2021 at 01:30:07PM +0200, Martin Kletzander wrote:
> The sourced tests/functions.sh uses bashisms like arrays and bash for loops.
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  golang/run-tests.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/golang/run-tests.sh b/golang/run-tests.sh
> index 9009685b49dd..6857047c7a4a 100755
> --- a/golang/run-tests.sh
> +++ b/golang/run-tests.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh -
> +#!/bin/bash -
>  # nbd client library in userspace
>  # Copyright (C) 2013-2020 Red Hat Inc.
>  #

Yes, this kind of change is generally good, since we require bash
(even on *BSD).  If you find any more like this, just change them.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]