[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [libnbd PATCH 4/5] golang: Check for module support

On Fri, May 07, 2021 at 07:17:00AM -0500, Eric Blake wrote:
On 5/6/21 6:30 AM, Martin Kletzander wrote:
If golang does not support modules, then it is too old anyway.

Signed-off-by: Martin Kletzander <mkletzan redhat com>
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 3b51354346cc..31130218a1e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -494,7 +494,7 @@ AS_IF([test "x$enable_golang" != "xno"],[
     AS_IF([test "x$GOLANG" != "xno"],[
         AC_MSG_CHECKING([if $GOLANG is usable])
-        AS_IF([$GOLANG run $srcdir/golang/config-test.go 2>&AS_MESSAGE_LOG_FD],[
+        AS_IF([$GOLANG run $srcdir/golang/config-test.go && $GOLANG help modules >/dev/null 2>&AS_MESSAGE_LOG_FD],[

Long line; I'd break after the &&.

Also, why are you not sending the output of config-test.go to
AS_MESSAGE_LOG_FD any more?  And why send stdout to /dev/null?  Either
you have to repeat the redirections, or you should group the two commands:

AS_IF([{$GOLANG run ... && $GOLANG help; } 2>&AS_MESSAGE_LOG_FD

I did not manage to make autoconf like anything else than the repeated
command redirections, so I switched to that.  I also added 1>&2 to send
the stdout to the log as well so that it does not needlessly pollute the
configure output.


             # Print the version to help with debugging.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]