On Tue, May 11, 2021 at 01:34:19PM +0100, Richard W.M. Jones wrote:
On Tue, May 11, 2021 at 12:16:19PM +0100, Richard W.M. Jones wrote:On Thu, May 06, 2021 at 01:30:05PM +0200, Martin Kletzander wrote: > FreeBSD > ======= > > The build fails because there is no fallocate() there. I'm actually not seeing a failure (FreeBSD 12.2). Do you happen to know what the build error was? I'm seeing test failures though which I'll fix if they are easy. I think for non-Linux right now I'm most concerned about build failures.Another problem with the libnbd tests is that they use the installed nbdkit, but -- presumably for political rather than technical reasons -- nbdkit on FreeBSD is built without GnuTLS support. While I could add 'requires' lines everywhere to test this, it may be better (on FreeBSD) to either not test against nbdkit at all or to test against the latest nbdkit build. Could CI tests allow this? Don't worry about implementing this, I just want to know what's possible.
That is a future plan after basic functionality is working. I am still debating whether running both builds make sense (with and without building own nbdkit). For nbdkit I will go with the same (running against self-built libnbd and maybe without it as well).
The situation for testing nbdkit is similar but reversed. FreeBSD does not package libnbd at all so far, but I'm quite sure they'll also build a TLS-less version if they get around to it. Someone requested a version of libnbd that supported OpenSSL as an alternative crypto backend recently. I wonder if they were a *BSD developer? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW
Description: PGP signature