[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [libnbd PATCH 0/5] Introduce automated testing using GitLab CI



On Wed, May 12, 2021 at 10:21:57PM +0200, Martin Kletzander wrote:
> On Tue, May 11, 2021 at 12:16:19PM +0100, Richard W.M. Jones wrote:
> >On Thu, May 06, 2021 at 01:30:05PM +0200, Martin Kletzander wrote:
> >>This is reworked version of
> >>
> >>  https://listman.redhat.com/archives/libguestfs/2021-March/msg00134.html
> >>
> >>with more packages installed so that more code paths are tested, also some fixes
> >>in the code (mostly requirements).
> >>
> >>There are still some things that fail.
> >>
> >>FreeBSD
> >>=======
> >>
> >>The build fails because there is no fallocate() there.
> >
> >I'm actually not seeing a failure (FreeBSD 12.2).  Do you happen to
> >know what the build error was?
> >
> 
> The error is visible here:
> 
>   https://gitlab.com/nertpinx/libnbd/-/jobs/1237433032#L2185

Oh I see, this is in fact a bug.  (Kind of, it's actually just a
harmless warning that you only see with --enable-gcc-warnings, but
best to fix it anyway).  I'll push a fix for this shortly.

The system works!

> >>Both interop-qemu-nbd-tls-certs and interop-qemu-nbd-tls-psk get
> >>skipped because they are missing the keys, but I presume those are
> >>supposed to be generated.
> >
> >These require "certtool" (part of gnutls).
> >
> 
> I made sure I installed gnutls-bin (or whatever gnutls package provides
> certtool), but I might've missed that certool is in another package on
> some particular distro.

It should be in gnutls-bin in Debian/Ubuntu.  We also need psktool
from the same package.

  https://packages.debian.org/search?searchon=contents&keywords=certtool&mode=path&suite=stable&arch=any

./configure output should say:

  checking for certtool... certtool
  checking for psktool... psktool

tests/pki/* is created by this script:

  https://gitlab.com/nbdkit/libnbd/-/blob/master/tests/make-pki.sh

while tests/keys.psk is created by running psktool from tests/Makefile.

Anyway it's not a big deal.  We can revisit skipped tests later once
everything is up and running.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]