[Libguestfs] [PATCH] build: Don't use non-POSIX tests

Martin Kletzander mkletzan at redhat.com
Mon May 31 19:16:29 UTC 2021


The `test` builtin/binary usually accepts `==` for string comparison, it is
mostly accepted for typos and people being used to double equals, but is not
documented and not always accepted either.  Since autoconf uses the default
shell, it might just fail in some cases with:

    ./configure: 29986: test: xrustc: unexpected operator
    ./configure: 29990: test: xcargo: unexpected operator

Just change it to single equals as it is done everywhere else.

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
 m4/guestfs-rust.m4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/guestfs-rust.m4 b/m4/guestfs-rust.m4
index aa12a9ef5e5d..1dffd8118874 100644
--- a/m4/guestfs-rust.m4
+++ b/m4/guestfs-rust.m4
@@ -24,8 +24,8 @@ AS_IF([test "x$enable_rust" != "xno"],[
     AC_CHECK_PROG([RUSTC],[rustc],[rustc],[no])
     AC_CHECK_PROG([CARGO],[cargo],[cargo],[no])
 
-    AS_IF([test "x$RUSTC" == "xno"], [AC_MSG_WARN([rustc not found])])
-    AS_IF([test "x$CARGO" == "xno"], [AC_MSG_WARN([cargo not found])])
+    AS_IF([test "x$RUSTC" = "xno"], [AC_MSG_WARN([rustc not found])])
+    AS_IF([test "x$CARGO" = "xno"], [AC_MSG_WARN([cargo not found])])
 ],[
     RUSTC=no
     CARGO=no
-- 
2.31.1




More information about the Libguestfs mailing list