[Libguestfs] libnbd | Failed pipeline for master | 70da51e5

[Martin Kletzander]

On Thu, Sep 02, 2021 at 05:12:35PM +0100, Richard W.M. Jones wrote:
>Hi Martin,
>
>On Thu, Sep 02, 2021 at 04:05:56PM +0000, GitLab wrote:
>> GitLab
>>                ✖ Pipeline #364204388 has failed!
>>
>> Project       nbdkit / libnbd
>> Branch        ● master
>> Commit        ● 70da51e5
>>               interop: Link interop-nbd-server-tls with -lgnu...
>> Commit Author ● Richard W.M. Jones
>>
>>     Pipeline #364204388 triggered by ●   Richard W.M. Jones
>>                         had 1 failed job.
>>                           Failed jobs
>> ✖ builds x64-opensuse-tumbleweed
>> GitLab
>
>This is failing on a new test I added, but it's failing because of how
>a particular package is built in OpenSUSE.
>
>The new test is:
>
>  https://gitlab.com/nbdkit/libnbd/-/commit/c833fa1226092fd51b1211fa195a2a3b791a4ee9
>
>which tries to test libnbd client with TLS enabled against nbd-server.
>nbd-server in OpenSUSE gives this error:
>
>  Error: inetd mode requires syslog
>  Exiting.
>
>which means it was compiled without --enable-syslog.
>
>I notice that the related test is skipped:
>
>  SKIP: interop-nbd-server
>  ========================
>
>  Test skipped based on ci/skipped_tests file
>  SKIP interop-nbd-server (exit status: 77)
>
>The format of ci/skipped_tests is pretty odd.  Is this patch OK?
>

Yes, I know, feel free to suggest anything better.  The patch is ok.

>diff --git a/ci/skipped_tests b/ci/skipped_tests
>index e2de9330..c494b9eb 100644
>--- a/ci/skipped_tests
>+++ b/ci/skipped_tests
>@@ -1,9 +1,9 @@
> # Old nbd-server and built without syslog support, tests deadlock, old qemu-img version
>-^Ubuntu-18\.04$;interop/interop-nbd-server interop/list-exports-nbd-server interop/structured-read.sh
>-^openSUSE Leap-15;interop/interop-nbd-server interop/list-exports-nbd-server
>+^Ubuntu-18\.04$;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server interop/structured-read.sh
>+^openSUSE Leap-15;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server
>
> # Similar for Tumbleweed, except tests do not deadlock, only limit to version 2021* for now
>-^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/list-exports-nbd-server
>+^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server
>
> # Debian 10 has weird golang issues (old golang anyway) and old qemu-img
> ^Debian GNU/Linux-10;golang/run-tests.sh interop/structured-read.sh
>

ACK

>
>Rich.
>
>-- 
>Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
>Read my programming and virtualization blog: http://rwmj.wordpress.com
>virt-top is 'top' for virtual machines.  Tiny program with many
>powerful monitoring features, net stats, disk stats, logging, etc.
>http://people.redhat.com/~rjones/virt-top
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20210903/540fc5bf/attachment.sig>