[Libguestfs] [guestfs-tools PATCH 1/3] Makefile.am: fix $(LIBGUESTFS_CFLAGS) typo for virt-ls

Laszlo Ersek lersek at redhat.com
Mon Sep 6 11:43:12 UTC 2021


Commit 4354a3126152 ("Add build system.", 2021-03-11) added
$(LIBGUESTFS_LIBS) to "virt_ls_CFLAGS" and "virt_ls_LDADD" both.

Correct the former; it should carry $(LIBGUESTFS_CFLAGS). Currently, the
command

> $ ../libguestfs/run make

produces the error

>   CC       virt_ls-ls.o
> ls.c:47:10: fatal error: guestfs.h: No such file or directory
>    47 | #include "guestfs.h"
>       |          ^~~~~~~~~~~

Fixes: 4354a3126152a2748cc9097cba139b3908ccc342
Signed-off-by: Laszlo Ersek <lersek at redhat.com>
---
 cat/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cat/Makefile.am b/cat/Makefile.am
index 39d0d25576eb..f1de5c866987 100644
--- a/cat/Makefile.am
+++ b/cat/Makefile.am
@@ -138,9 +138,9 @@ virt_ls_CPPFLAGS = \
 
 virt_ls_CFLAGS = \
 	$(WARN_CFLAGS) $(WERROR_CFLAGS) \
 	$(LIBXML2_CFLAGS) \
-	$(LIBGUESTFS_LIBS)
+	$(LIBGUESTFS_CFLAGS)
 
 virt_ls_LDADD = \
 	$(top_builddir)/common/options/liboptions.la \
 	$(top_builddir)/common/visit/libvisit.la \
-- 
2.19.1.3.g30247aa5d201




More information about the Libguestfs mailing list