[Libguestfs] [hivex PATCH 8/8] build: allow OCaml programs using hivex to be compiled against build dir

Richard W.M. Jones rjones at redhat.com
Thu Sep 9 11:08:41 UTC 2021

On Thu, Sep 09, 2021 at 12:42:45PM +0200, Laszlo Ersek wrote:
> On 09/08/21 17:49, Richard W.M. Jones wrote:
> > 
> > Yes the series looks fine, ACK series.
> Thanks!
> > I think the presence of $(top_builddir)/lib to look for the header
> > file was likely a copy-paste thing from some other project.  The
> > generator always writes files into the source directory (or if you
> > build from the tarball, everything is already in the source directory.)
> Right, I'd not been familiar with autotools internals, so I first needed
> to understand that the generator ran during autogen, and (therefore) its
> output would be included by "make dist" in the *source* tree.

It's because we want to allow people to build from tarballs without
needing the ocamlc dependency.

It may not be necessary any longer, but it's what we're doing now.


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch

More information about the Libguestfs mailing list