[Libguestfs] [PATCH nbdinfo v2 1/3] common/utils: Add function to convert sizes to human-readable

Richard W.M. Jones rjones at redhat.com
Mon Sep 20 17:12:28 UTC 2021


On Mon, Sep 20, 2021 at 05:56:06PM +0100, Daniel P. Berrangé wrote:
> On Mon, Sep 20, 2021 at 05:39:59PM +0100, Richard W.M. Jones wrote:
> > I'd usually follow what qemu or libvirt are doing, and as far as I can
> > see they are not using these.
> 
> It is a non-trivial undertaking for any established project with
> multiple copyright holders.
> 
> The license header is generally not something you are permitted to
> change generally unless you are the copyright holder, or have the
> copy holders' agreement.  Despite this, we can see the kernel did
> such a switch, replacing license headers with SPDX tags. My
> understanding though, is that there was work done behind scenes
> with legal input before they actually merged the patches, as a
> means to justify this change.
> 
> On any newly written project I'd certainly use SPDX, but IMHO
> for existing projects it isn't viable unless we see clear legal
> advice explaining a process to follow that makes it acceptable
> to replace license text with SPDX.

This is true.  We actually had to get agreement from all copyright
holders before we removed a single line from the nbdkit copyright
notices and that was a right PITA:

https://gitlab.com/nbdkit/nbdkit/-/commit/952ffe0fc7685ea775ed8879bf0b2cb9df3d9044

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top




More information about the Libguestfs mailing list