[Libguestfs] [virt-v2v PATCH 4/4] test-v2v-i-ova: spell out viosock element in output domain XML

[Laszlo Ersek]

On 09/27/21 10:32, Richard W.M. Jones wrote:
> On Mon, Sep 27, 2021 at 08:34:58AM +0200, Laszlo Ersek wrote:
>> This is likely an omission from commit 05f780c16f01 ("v2v: support
>> configuration of viosock driver", 2021-02-26) -- if the converted Windows
>> guest does not dispose over the virtio-sock guest drivers, an explicit
>> "none"-model element is now generated in the domain XML.
>>
>> Fixes: 05f780c16f0135c657615520c2245b42de1efc3e
>> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
>> ---
>>  tests/test-v2v-i-ova.xml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/test-v2v-i-ova.xml b/tests/test-v2v-i-ova.xml
>> index a018fd44aee8..489c0ab09bcc 100644
>> --- a/tests/test-v2v-i-ova.xml
>> +++ b/tests/test-v2v-i-ova.xml
>> @@ -46,6 +46,7 @@
>>        <backend model='random'>/dev/urandom</backend>
>>      </rng>
>>      <memballoon model='virtio'/>
>> +    <viosock model='none'/>
>>      <input type='tablet' bus='usb'/>
>>      <input type='mouse' bus='ps2'/>
>>      <console type='pty'/>
> 
> Patches 1 & 4 are good.

Thanks! I pushed them as commits 3767ebca30c5 and 5adf437bcc00 respectively.

I also synthesized an Acked-by in your name for each commit, from the
above "good". (If I shouldn't do that, please let me know.)

Thanks,
Laszlo

> 
> Patches 2 & 3 are symptoms of the incomplete fix:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1581428
> https://bugzilla.redhat.com/show_bug.cgi?id=1637857
> 
> so need some different work (although fixing the test will be part of
> the solution).
> 
> Rich.
>