[Libguestfs] virt-p2v VM testing bitrot?

[Laszlo Ersek]

On 08/25/22 15:06, Richard W.M. Jones wrote:
> On Thu, Aug 25, 2022 at 02:42:54PM +0200, Laszlo Ersek wrote:
>> I'd like to implement it in a separate script.
>>
>> Do I have to list that script under EXTRA_DIST?
> 
> Usually yes, because we'd want it to go into the *.tar.gz
> file which is how some distros (eg. Fedora) consume virt-p2v.
> 
> There is a useful rule:
> 
>   make dist && make maintainer-check-extra-dist
> 
> which should check that all files necessary are listed in EXTRA_DIST
> (or pulled in implicitly - you don't need EXTRA_DIST for *_SOURCES and
> a few other things).
> 
>> What other Makefile macros?
> 
> I'd do something like:
> 
>   check_SCRIPTS = my_script.sh
> 
> which tells automake that 'my_script.sh' is needed for 'make check'.
> 
> If the script needs @foo@ autoconf expansions, then create a file
> called 'my_script.sh.in' and add that to configure.ac.  See existing
> AC_CONFIG_FILES entries.
> 
> I think check_SCRIPTS and/or AC_CONFIG_FILES implicitly adds the
> script or its source to EXTRA_DIST.
> 
> Rich.
> 

Thanks -- I added check_SCRIPTS, but then I also needed to extend
EXTRA_DIST ("make maintainer-check-extra-dist" complained).

Laszlo