[Libguestfs] [PATCH libnbd] golang: tests: Fix error handling
Eric Blake
eblake at redhat.com
Thu Feb 3 19:24:24 UTC 2022
On Thu, Feb 03, 2022 at 08:07:52PM +0200, Nir Soffer wrote:
> Like lot of the C examples, the aio copy test ignores read and write
> errors in the completion callback, which can cause silent data
> corruption. The failure in the test is not critical, but this is a bad
> example that may be copied by developers to a real application.
>
> The test panics now if completion callback fails, similar to other Go
> examples.
>
> Signed-off-by: Nir Soffer <nsoffer at redhat.com>
> ---
> golang/libnbd_590_aio_copy_test.go | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
ACK.
python/t/590-aio-copy.py and ocaml/tests/test_490_aio_copy.ml need the
same treatment. I'll post that with my v2 of the CVE fix.
(It's nice that we've tried to share the same test numbers across
language bindings - it makes it a bit easier where we copy the same
coding paradigms across different languages)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
More information about the Libguestfs
mailing list