[Libguestfs] [libnbd PATCH v2 5/5] copy: CVE-2022-0485: Fail nbdcopy if NBD read or write fails

[Richard W.M. Jones]

On Fri, Feb 04, 2022 at 02:08:21AM +0200, Nir Soffer wrote:
> On Thu, Feb 3, 2022 at 10:26 PM Eric Blake <eblake at redhat.com> wrote:
> > +  if (*error) {
> > +    fprintf (stderr, "read at offset 0x%" PRIx64 "failed: %s\n",
> 
> Good error message, but  there is missing space before "failed".
>
> Why use hex offset? I find it very confusing. I don't think nbdcopy users
> think in hex.

Yes, both good points.  All offsets are printed in decimal elsewhere.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW