[Libguestfs] [libnbd PATCH] copy: Fail nbdcopy if NBD read or write fails

Richard W.M. Jones rjones at redhat.com
Tue Feb 8 13:43:17 UTC 2022


On Fri, Feb 04, 2022 at 09:18:07AM +0100, Laszlo Ersek wrote:
> (And there was no easy way to skip connect-tcp6.)

Wwe use this in libnbd.spec:

https://src.fedoraproject.org/rpms/libnbd/blob/rawhide/f/libnbd.spec#_214

In libguestfs we have a whole infrastructure for skipping tests by
setting $SKIP_* variables in localenv.

https://libguestfs.org/guestfs-building.1.html#local-files
https://github.com/libguestfs/libguestfs/blob/0553f90462f456b1fe7100346aa1a4f12fccb288/tests/test-functions.sh#L39

For libnbd/nbdkit it might be possible to automate it in the same way
with tests/functions.sh.in + $0, but it's not implemented at the
moment.  Of course it'd be better if the tests didn't fail :-)

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW




More information about the Libguestfs mailing list