[Libguestfs] [PATCH nbdkit] tls-fallback: Always call next open function

Richard W.M. Jones rjones at redhat.com
Wed Feb 16 21:51:24 UTC 2022


On Wed, Feb 16, 2022 at 09:25:50PM +0000, Richard W.M. Jones wrote:
> This fixes a crash when using --filter=tls-fallback.  It happens to
> only occur with my block_size patch series and is easily reproducible
> (see commit message).  I believe the problem is generic although I
> couldn't work out how to trigger in unpatched nbdkit.
> 
> tls-fallback filter has a scary comment which seems to indicate that
> calling the next open is wrong (unsafe?) in the !tls case.  So I don't
> know if this change is really right.

Ignore this patch, see second one just posted.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW




More information about the Libguestfs mailing list