[Libguestfs] [PATCH nbdkit v2 7/7] New filter: nbdkit-block-size-constraint-filter

Richard W.M. Jones rjones at redhat.com
Thu Feb 17 22:00:52 UTC 2022


On Thu, Feb 17, 2022 at 03:58:07PM -0600, Eric Blake wrote:
> The NBD protocol spec recommends EINVAL (rather than EIO) for requests
> that violate block size constraints.  Do we want to hardcode EINVAL,
> or else tweak the error policy to allow the user to specify which
> errno to provide?

I err on not overthinking this.  I'll change it to EINVAL, and if ever
we need to choose another errno then we can add a knob for it.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/




More information about the Libguestfs mailing list