[Libguestfs] [PATCH nbdkit] cache, cow: Export block size constraints

[Richard W.M. Jones]

On Mon, Feb 21, 2022 at 10:22:04AM +0100, Laszlo Ersek wrote:
> > +/* Block size constraints. */
> > +static int
> > +cache_block_size (nbdkit_next *next, void *handle,
> > +                  uint32_t *minimum, uint32_t *preferred, uint32_t *maximum)
> > +{
> > +  if (next->block_size (next, minimum, preferred, maximum) == -1)
> > +    return -1;
> > +
> > +  if (*minimum == 0) {         /* No constraints set by the plugin. */
> > +    *minimum = 1;
> > +    *preferred = blksize;
> > +    *maximum = 0xffffffff;
> > +  }
> > +  else if (*maximum >= blksize) {
> 
> Do we need braces here?
> 
> > +    *preferred = MAX (*preferred, blksize);
> > +  }

I don't think we need them, but it might be clearer with them.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html