[Libguestfs] [libguestfs-common PATCH 2/3] options: remove stale comment about GUESTFS_CRYPTSETUP_OPEN_READONLY

[Laszlo Ersek]

When the appliance opens the disk image in read-only mode, it uses a
writeable qcow2 overlay to protect the disk image from writes. Writable
guest devices are required to mount filesystems with journals, even when
mounting them with "-o ro".

Suggested-by: Richard W.M. Jones <rjones at redhat.com>
Signed-off-by: Laszlo Ersek <lersek at redhat.com>
---
 options/decrypt.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/options/decrypt.c b/options/decrypt.c
index 6e0ea95f1716..c5b8f8f566fd 100644
--- a/options/decrypt.c
+++ b/options/decrypt.c
@@ -113,9 +113,6 @@ decrypt_mountables (guestfs_h *g, const char * const *mountables,
       int r;
 
       guestfs_push_error_handler (g, NULL, NULL);
-      /* XXX Should we set GUESTFS_CRYPTSETUP_OPEN_READONLY if readonly is
-       * set?  This might break 'mount_ro'.
-       */
       r = guestfs_cryptsetup_open (g, mountable, key, mapname, -1);
       guestfs_pop_error_handler (g);
 
-- 
2.19.1.3.g30247aa5d201