[Libguestfs] [p2v PATCH] virt-p2v-make-*.in: make @datadir@ and @libdir@ resolvable

[Eric Blake]

On Wed, Jul 20, 2022 at 01:53:22PM +0200, Laszlo Ersek wrote:
> ./configure expands @datadir@ and @libdir@ to "${prefix}/share" and
> "${exec_prefix}/lib" by default (verbatim); $prefix and $exec_prefix are
> supposed to be substituted by the shell when the generated shell scripts
> are executed.
> 
> For this, capture the prefix and exec_prefix values at the time
> ./configure runs.
> 
> This fixes failures such as
> 
> > $ virt-p2v-make-kickstart fedora
> > base64: /share/virt-p2v/issue: No such file or directory
> 
> for such scripts that were installed with "make install".
> 

> +++ b/virt-p2v-make-disk.in
> @@ -20,6 +20,8 @@ unset CDPATH
>  
>  program="virt-p2v-make-disk"
>  version="@PACKAGE_VERSION@"
> +prefix="@prefix@"
> +exec_prefix="@exec_prefix@"

I'm late to the conversation, but I also recommend adding a third line:

datarootdir="@datarootdir@"

as it will then silence the autoconf warnings about not honoring
--datarootdir in a file that dereferenced @datadir at .

With that addition in all relevant .in files,

Acked-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org