[Libguestfs] [nbdkit PATCH] tests: Better quoting for cleanup_fn

Richard W.M. Jones rjones at redhat.com
Mon Jul 25 21:35:23 UTC 2022


On Mon, Jul 25, 2022 at 10:01:21AM -0500, Eric Blake wrote:
> On Mon, Jul 25, 2022 at 04:13:41PM +0200, Laszlo Ersek wrote:
> 
> > > That is, our commands were munged by IFS splitting, because we stored
> > > commands in a flat variable.  Fix it by instead using an array
> > > variable per cleanup_fn invocation.
> > > 
> 
> > 
> > Reviewed-by: Laszlo Ersek <lersek at redhat.com>
> >
> 
> In nbdkit as 6699ca24
> In libnbd as 0cf89848

Patch looks good, thanks.

I agree about reversing the cleanups - hard to know where all the
implicit assumptions could be, especially in failure cases.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top


More information about the Libguestfs mailing list