[Libguestfs] [nbdkit PATCH 3/3] tests: Add regression test for NBDKIT_EMULATE_CACHE fix

[Richard W.M. Jones]

Series looks good:

Acked-by: Richard W.M. Jones <rjones at redhat.com>

I think nbdkit-ext2-filter is still wrong (although at least it should
no longer corrupt disk images) because it unnecessarily calls
next->can_zero, so it might be worth dropping those two lines.

Regression test for the LUKS case might be useful.  But note that the
test should not only check that zeroes work, but also that the result
is still a LUKS image.  The reason is that a naive fix for the earlier
problem can (as I discovered) corrupt the disk image, because it will
forward zeroes (eg to offset 0) straight through to the plugin.  If
this is too much, then I can write this test case tomorrow.

Thanks!

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v