[Libguestfs] [PATCH nbdkit] vddk: Demote another useless phone-home error message to debug

[Richard W.M. Jones]

On Tue, May 10, 2022 at 08:52:23AM -0500, Eric Blake wrote:
> > -  if (strstr (str, "Get CEIP status failed") != NULL) {
> > +  if (strstr (str, "Get CEIP status failed") != NULL ||
> > +      strstr (str, "VDDK_PhoneHome: Unable to load configuration "
> > +                   "options from ") != NULL) {
> 
> Could there ever be locale issues where this message from VDDK might
> be translated and thus not trigger our simple strstr() check?  Or are
> we careful in nbdkit to force a known locale onto vddk, even if it is
> different than the user's default locale?

The message comes from VDDK (library side) and this library doesn't
appear to do any kind of translation at all.  So although we don't
force a known locale, either in nbdkit nor when running nbdkit from
virt-v2v, I don't think this string could change.

It's only a cosmetic thing: if the string changes in future all that
happens is it gets sent through nbdkit_error instead of nbdkit_debug,
but conversion continues regardless.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW