[Libguestfs] [PATCH v2v] convert: Ignore /dev/mapper/osprober-* devices when trimming

Laszlo Ersek lersek at redhat.com
Tue May 17 10:29:23 UTC 2022


On 05/17/22 11:48, Laszlo Ersek wrote:

> Do you think it's feasible to *move* the name-based filtering from
> virt-v2v's do_fstrim to the libguestfs daemon's list-filesystems API
> implementation? I can't see a reason why the list-filesystems API should
> *ever* return these /dev/mapper/osprober-* nodes.
> 
> IOW all I'm proposing is that we move the same workaround deeper in the
> stack.

Scratch that -- that still allows the grub2/osprober bug to spread too far.

Once we get some info from the rhboot team on the nature of this
grub2/osprober bug, can we perhaps unmount and "dmsetup remove" these
/dev/mapper/osprober-* block devices, in v2v, right after we call
"grub2_mkconfig_cmd"? That would contain this issue tightly.

Thanks
Laszlo


More information about the Libguestfs mailing list