[Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain does not exist

Richard W.M. Jones rjones at redhat.com
Thu Jan 26 12:31:07 UTC 2023


Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1986386
Reported-by: Junqin Zhou
---
 output/rhv-upload-precheck.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/output/rhv-upload-precheck.py b/output/rhv-upload-precheck.py
index 1dc1b8498a..35ea021032 100644
--- a/output/rhv-upload-precheck.py
+++ b/output/rhv-upload-precheck.py
@@ -81,7 +81,12 @@ datacenter = data_centers[0]
 
 # Get the storage domain.
 storage_domains = connection.follow_link(datacenter.storage_domains)
-storage_domain = [sd for sd in storage_domains if sd.name == params['output_storage']][0]
+try:
+    storage_domain = [sd for sd in storage_domains \
+                      if sd.name == params['output_storage']][0]
+except IndexError:
+    raise RuntimeError("The storage domain ‘%s’ does not exist" %
+                       params['output_storage'])
 
 # Get the cluster.
 clusters = connection.follow_link(datacenter.clusters)
-- 
2.39.0



More information about the Libguestfs mailing list