[Libguestfs] [p2v PATCH 01/11] test-virt-p2v-cmdline: turn option list into a shell array

Laszlo Ersek lersek at redhat.com
Mon Jan 30 14:22:18 UTC 2023


The argument for virt-p2v's "--cmdline" option has grown huge. Break it to
multiple lines. That's easiest to do with a shell array.

Cc: Alban Lecorps <alban.lecorps at ubisoft.com>
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1792141
Signed-off-by: Laszlo Ersek <lersek at redhat.com>
---
 test-virt-p2v-cmdline.sh | 22 +++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/test-virt-p2v-cmdline.sh b/test-virt-p2v-cmdline.sh
index 79c3061b1e7c..7d5434cf8428 100755
--- a/test-virt-p2v-cmdline.sh
+++ b/test-virt-p2v-cmdline.sh
@@ -26,7 +26,27 @@ out=test-virt-p2v-cmdline.out
 rm -f $out
 
 # The Linux kernel command line.
-$VG virt-p2v --cmdline='p2v.server=localhost p2v.port=123 p2v.username=user p2v.password=secret p2v.skip_test_connection p2v.name=test p2v.vcpu.cores=4 p2v.memory=1G p2v.disks=sda,sdb,sdc p2v.removable=sdd p2v.interfaces=eth0,eth1 p2v.o=local p2v.oa=sparse p2v.oc=qemu:///session p2v.of=raw p2v.os=/var/tmp p2v.network=em1:wired,other p2v.dump_config_and_exit' > $out
+P2V_OPTS=(
+  p2v.server=localhost
+  p2v.port=123
+  p2v.username=user
+  p2v.password=secret
+  p2v.skip_test_connection
+  p2v.name=test
+  p2v.vcpu.cores=4
+  p2v.memory=1G
+  p2v.disks=sda,sdb,sdc
+  p2v.removable=sdd
+  p2v.interfaces=eth0,eth1
+  p2v.o=local
+  p2v.oa=sparse
+  p2v.oc=qemu:///session
+  p2v.of=raw
+  p2v.os=/var/tmp
+  p2v.network=em1:wired,other
+  p2v.dump_config_and_exit
+)
+$VG virt-p2v --cmdline="${P2V_OPTS[*]}" > $out
 
 # For debugging purposes.
 cat $out



More information about the Libguestfs mailing list