[Libguestfs] [nbdkit PATCH 1/2] retry: Add in retry support during .open

[Eric Blake]

On Sat, Jan 28, 2023 at 01:47:32PM +0000, Richard W.M. Jones wrote:
> On Fri, Jan 27, 2023 at 02:41:22PM -0600, Eric Blake wrote:
> > Now that a filter can open a backend as many times as it wants,
> > there's no longer a technical reason we can't retry .open.  However,
> > adding retry logic here does mean we have to weaken an assert in the
> > server backend code, since prepare can now be reached more than once.
> > 
> > Test coverage will be added in a separate patch, so that it becomes
> > easy to swap patch order and see that the test fails without this
> > patch.
> > 
> > See also https://bugzilla.redhat.com/show_bug.cgi?id=1841820
> > ---
> 
> Seems OK, ACK (modulo your comment about leaking memory
> in your reply).
> 
> I checked the documentation of the filter and it doesn't mention the
> limitation, so it seems we don't need to adjust the documentation at
> all.

The memory bug is fixed, and this is now in as commits
42b198c9..4aabef5e

> 
> I will try this out with the ssh filter once the bug moves into post.

Ready for you to test.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org