[Libguestfs] [PATCH nbdkit v2 4/6] common/include: Make log_2_bits work on 64 bit ints

Eric Blake eblake at redhat.com
Wed May 17 21:36:32 UTC 2023


On Wed, May 17, 2023 at 11:06:57AM +0100, Richard W.M. Jones wrote:
> Previously it only worked for 64 bit ints on 64 bit platforms, but we
> can easily adjust the function to work on any platform.
> ---
>  common/include/ispowerof2.h      | 4 ++--
>  common/include/test-ispowerof2.c | 6 ++----
>  2 files changed, 4 insertions(+), 6 deletions(-)

Should we also fix is_power_of_2() to work on 64-bit values on all
platforms?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


More information about the Libguestfs mailing list