[Libguestfs] [libguestfs PATCH 3/3] LUKS-on-LVM inspection test: test /dev/mapper/VG-LV translation

[Laszlo Ersek]

On 5/19/23 18:28, Richard W.M. Jones wrote:
> On Fri, May 19, 2023 at 04:08:49PM +0200, Laszlo Ersek wrote:
>> In the LUKS-on-LVM inspection test, call the "check_filesystems" function
>> yet another time, now with such "--key" options that exercise the recent
>> "/dev/mapper/VG-LV" -> "/dev/VG/LV" translation (unescaping) from
>> libguestfs-common.
>>
>> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2168506
>> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
>> ---
>>  tests/luks/test-key-option-inspect-luks-on-lvm.sh | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>
>> diff --git a/tests/luks/test-key-option-inspect-luks-on-lvm.sh b/tests/luks/test-key-option-inspect-luks-on-lvm.sh
>> index a8d72b9f9463..932862b17d4a 100755
>> --- a/tests/luks/test-key-option-inspect-luks-on-lvm.sh
>> +++ b/tests/luks/test-key-option-inspect-luks-on-lvm.sh
>> @@ -101,3 +101,21 @@ eval "$fish_ref"
>>  
>>  # Repeat the test.
>>  check_filesystems
>> +
>> +# Exit the current guestfish background process.
>> +guestfish --remote -- exit
>> +GUESTFISH_PID=
>> +
>> +# Start up another guestfish background process, and specify the keys in
>> +# /dev/mapper/VG-LV format this time.
>> +keys_by_mapper_lvname=(
>> +  --key /dev/mapper/Volume--Group-Root:key:FEDORA-Root
>> +  --key /dev/mapper/Volume--Group-Logical--Volume--1:key:FEDORA-LV1
>> +  --key /dev/mapper/Volume--Group-Logical--Volume--2:key:FEDORA-LV2
>> +  --key /dev/mapper/Volume--Group-Logical--Volume--3:key:FEDORA-LV3
>> +)
>> +fish_ref=$("${guestfish[@]}" "${keys_by_mapper_lvname[@]}")
>> +eval "$fish_ref"
>> +
>> +# Repeat the test.
>> +check_filesystems
> 
> For the series:
> 
> Reviewed-by: Richard W.M. Jones <rjones at redhat.com>

Commit range 692802bf96e0..32408a9c3616.

Thanks!
Laszlo