<div dir="ltr"><div><div><div><div>Hi Rich, </div>Thanks, again, for the pointer. I'm still slowly going through the registry making my changes. </div>I noticed what may be a small bug in your code. Please look at <a href="https://github.com/libguestfs/libguestfs/blob/master/v2v/windows_virtio.ml#L230-L231">https://github.com/libguestfs/libguestfs/blob/master/v2v/windows_virtio.ml#L230-L231</a>. I think you meant to have those two compat ids be: "PCI\\CC_010000"; "PCI\\CC_0100"; </div>The current IDs in your code try to associate the viostor driver with devices from vendor <a href="http://pcidatabase.com/vendor_details.php?id=406">http://pcidatabase.com/vendor_details.php?id=406</a>, which I don't believe was your intent. </div>JP </div><div class="gmail_extra"> <div class="gmail_quote">On Tue, Feb 9, 2016 at 12:35 AM, Richard W.M. Jones <<a href="mailto:rjones@redhat.com" target="_blank">rjones@redhat.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Feb 09, 2016 at 12:20:35AM -0800, Joshua Pincus wrote: > Hi Rich, > > Thanks for the pointer. It looks like add_viostor_to_driver_database() is > the routine that I need to mimic. I'll try that out in the morning. I've > been staring at this problem for so long that my eyes are crossing. I should note that any doubled \\ that appear in the strings are really single \, they are just escaped OCaml strings. It might help to fire up the OCaml interpreter: $ rlwrap ocaml OCaml version 4.02.3 # open Printf;; # printf "PCI\\VEN_1AF4&DEV_1001&REV_00\n";; PCI\VEN_1AF4&DEV_1001&REV_00 - : unit = () # let oem_inf = "oem1.inf";; val oem_inf : string = "oem1.inf" # printf "@%s,%%rhelscsi.devicedesc%%;Red Hat VirtIO SCSI controller\n" oem_inf;; @oem1.inf,%rhelscsi.devicedesc%;Red Hat VirtIO SCSI controller - : unit = () Rich. -- Richard Jones, Virtualization Group, Red Hat <a href="http://people.redhat.com/~rjones" rel="noreferrer" target="_blank">http://people.redhat.com/~rjones</a> Read my programming and virtualization blog: <a href="http://rwmj.wordpress.com" rel="noreferrer" target="_blank">http://rwmj.wordpress.com</a> virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. <a href="http://people.redhat.com/~rjones/virt-top" rel="noreferrer" target="_blank">http://people.redhat.com/~rjones/virt-top</a> </blockquote></div> </div>